Trim parsed input group keys to remove whitespace #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this small change? |
gkatsev
reviewed
Jul 21, 2022
lib/parser/parse-options.js
Outdated
| @@ -10,7 +10,7 @@ function parseOptions(input, callback, keyValueDelim, groupDelim) { | |||
| if (kv.length !== 2) { | |||
| continue; | |||
| } | |||
| var k = kv[0]; | |||
| var k = kv[0].trim(); | |||
| var v = kv[1]; | |||
There was a problem hiding this comment.
can we add a trim here too, just in case?
There was a problem hiding this comment.
Thanks for taking a look! Pushed up that change here.
gkatsev
approved these changes
Jul 22, 2022
misteroneill
pushed a commit
that referenced
this pull request
Aug 16, 2022
|
Did this make it into version 7.x yet? It's not trimmed in the online tester for 7.x: |
|
It's in 7.20.3 https://github.com/videojs/video.js/releases/tag/v7.20.3 |
|
Gotcha, thanks gkatsev! |
|
Just updated the version of video.js there (videojs/http-streaming#1340) it should be deployed in a few minutes. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a minor adjustment to the keys parsed from each input group in
lib/parser/parseOptions.js. This change will fix an issue first reported in videojs/http-streaming#982.Our video asset caption VTT files were generated in such a way that added an extra whitespace between the first group delimiter (
,) and the key "LOCAL" (example below). This extra whitespace, while apparently in-compliance with the HLS-segmented VTT spec, causes VTT.js's parseOptions function to not properly parse cues from the VTT files, resulting in empty text tracks being attached to our player.Example
WORKING:
BROKEN: